Refactor getContentFromChatResponse method to use Optional for null handling #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbyzhaox
changed the title
Member
|
@robbyzhaox Thanks for the clean up! Rebased and merged as 5783c5b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors getContentFromChatResponse to use Java's Optional for null handling. Initially, the method relied on explicit null checks for ChatResponse and its nested properties.
By replacing these with Optional chaining, the code is more streamlined, following Java 8+ best practices for handling nulls. This improves readability and reduces clutter from traditional null - checking.
Now, Optional.ofNullable safely manages the ChatResponse object, and map operations traverse nested objects, gracefully returning null if any link in the chain is null.